Font Library refactor: Migrate legacy font family content #58032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
creativecoder
added
[Type] Experimental
|
This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress. If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged. If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack. Thank you! ❤️ View changed files❔ phpunit/tests/fonts/font-library/fontFamilyBackwardsCompatibility.php ❔ lib/experimental/fonts/font-library/font-library.php |
mikachan
approved these changes
Jan 22, 2024
There was a problem hiding this comment.
I've given this a smoke test:
- Checkout this branch and check that fonts from trunk remain installed and working in the font library ✅
- I no longer see a client-side error when trying to load legacy-format fonts in the editor ✅
Database changes:
- The
gutenberg_font_family_format_convertedoption is set after the migration ✅ - The
fontFacejson array items contained withinwp_font_familycontent are moved to newly createdwp_font_faceposts ✅ - The old post_content within font families is backed up to
_gutenberg_legacy_font_family_formatpost meta for each family ✅ (It was saved under_gutenberg_legacy_font_family) - Font faces have
_wp_font_face_filepost meta created for their font file assets ✅
Approving as this is working well for me! This is a great way to handle the legacy format and functionality 👏
|
PHP unit tests are failing, but it doesn't seem to be this branch, as they are failing across the repo. |
creativecoder
merged this pull request
into
try/font-library-refactor
39 of 62 checks passed
creativecoder
added a commit
that referenced
this pull request
Jan 22, 2024
creativecoder
added a commit
that referenced
this pull request
Jan 23, 2024
* Font Library: add wp_font_face post type and scaffold font face REST API controller (#57656) * Font Library: create font faces through the REST API (#57702) * Refactor Font Family Controller (#57785) * Font Family and Font Face REST API endpoints: better data handling and errors (#57843) * Font Families REST API endpoint: ensure unique font family slugs (#57861) * Font Library: delete child font faces and font assets when deleting parent (#57867) * Font Library: refactor client side install functions to work with revised API (#57844) * Cleanup/font library view error handling (#57926) * Font Faces endpoint: prevent creating font faces with duplicate settings (#57903) * Font Library: Update uninstall/delete on client side (#57932) * Font Library: address JS feedback in #57688 (#57961) * Font Library REST API endpoints: address initial feedback from feature branch (#57946) * Font Library: font collection refactor to use the new schema (#57884) * Fix font asset download when font faces are installed (#58021) * Font Families and Faces: disable autosaves using empty class (#58018) * Adds migration for legacy font family content (#58032) --------- Co-authored-by: Jeff Ong <jonger4@gmail.com> Co-authored-by: Matias Benedetto <matias.benedetto@gmail.com> Co-authored-by: Jason Crist <jcrist@pbking.com> Co-authored-by: Sarah Norris <sarah@sekai.co.uk> Co-authored-by: Jonny Harris <spacedmonkey@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
In #57688, we are changing the post_content of
wp_font_familyposts and splitting out the font faces into separatewp_font_faceposts.This change adds a migration so fonts previously installed with the old format will continue working.
Why?
To prevent Gutenberg plugin users from loosing installed fonts when the refactor lands.
How?
Running a one-time migration function on the
inithook.Testing Instructions
You may also want to check that the database content is correct
gutenberg_font_family_format_convertedoption is set after the migrationfontFacejson array items contained withinwp_font_familycontent are moved to newly createdwp_font_faceposts_gutenberg_legacy_font_family_formatpost meta for each family_wp_font_face_filepost meta created for their font file assets